Browse Source

golangci-lint: replace deprecated golint with revive

master
Michael Eischer 8 months ago
parent
commit
af31266b7d
  1. 8
      .golangci.yml
  2. 2
      internal/fs/fs_local_vss.go
  3. 2
      internal/limiter/static_limiter_test.go
  4. 2
      internal/restic/node.go
  5. 2
      internal/ui/progress/counter_test.go

8
.golangci.yml

@ -24,7 +24,7 @@ linters:
- govet
# make sure names and comments are used according to the conventions
- golint
- revive
# detect when assignments to existing variables are not used
- ineffassign
@ -51,7 +51,7 @@ issues:
# list of things to not warn about
exclude:
# golint: do not warn about missing comments for exported stuff
- exported (function|method|var|type|const) `.*` should have comment or be unexported
# golint: ignore constants in all caps
# revive: do not warn about missing comments for exported stuff
- exported (function|method|var|type|const) .* should have comment or be unexported
# revive: ignore constants in all caps
- don't use ALL_CAPS in Go names; use CamelCase

2
internal/fs/fs_local_vss.go

@ -117,7 +117,7 @@ func (fs *LocalVss) snapshotPath(path string) string {
fs.msgMessage("creating VSS snapshot for [%s]\n", vssVolume)
if snapshot, err := NewVssSnapshot(vssVolume, 120, fs.msgError); err != nil {
_ = fs.msgError(vssVolume, errors.Errorf("failed to create snapshot for [%s]: %s\n",
_ = fs.msgError(vssVolume, errors.Errorf("failed to create snapshot for [%s]: %s",
vssVolume, err))
fs.failedSnapshots[volumeNameLower] = struct{}{}
} else {

2
internal/limiter/static_limiter_test.go

@ -56,7 +56,7 @@ func TestRoundTripperReader(t *testing.T) {
_, err := io.ReadFull(rand.Reader, data)
test.OK(t, err)
var send *tracedReadCloser = newTracedReadCloser(bytes.NewReader(data))
send := newTracedReadCloser(bytes.NewReader(data))
var recv *tracedReadCloser
rt := limiter.Transport(roundTripper(func(req *http.Request) (*http.Response, error) {

2
internal/restic/node.go

@ -166,7 +166,7 @@ func (node *Node) CreateAt(ctx context.Context, path string, repo Repository) er
case "socket":
return nil
default:
return errors.Errorf("filetype %q not implemented!\n", node.Type)
return errors.Errorf("filetype %q not implemented", node.Type)
}
return nil

2
internal/ui/progress/counter_test.go

@ -61,7 +61,7 @@ func TestCounter(t *testing.T) {
func TestCounterNil(t *testing.T) {
// Shouldn't panic.
var c *progress.Counter = nil
var c *progress.Counter
c.Add(1)
c.Done()
}

Loading…
Cancel
Save